Issue 12531013: Expanded map options to named parameters.

Issue 12531013: Expanded map options to named parameters. (Closed)

Created:
7 years, 9 months ago by Emily Fortuna

Modified:
7 years, 9 months ago

Reviewers:
blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Expanded map options to named parameters. BUG= Committed: https://code.google.com/p/dart/source/detail?r=20127

Patch Set 3 : #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+452 lines, -202 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View		17 chunks	+160 lines, -72 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		15 chunks	+120 lines, -46 lines	0 comments	Download
M	tests/html/fileapi_test.dart	View		4 chunks	+11 lines, -17 lines	0 comments	Download
M	tests/html/notifications_test.dart	View	1 2	1 chunk	+1 line, -2 lines	0 comments	Download
M	tools/dom/scripts/htmldartgenerator.py	View		2 chunks	+12 lines, -2 lines	0 comments	Download
M	tools/dom/scripts/htmlrenamer.py	View	1	3 chunks	+5 lines, -3 lines	0 comments	Download
M	tools/dom/scripts/systemhtml.py	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
D	tools/dom/templates/html/dart2js/impl_Notification.darttemplate	View		1 chunk	+0 lines, -17 lines	0 comments	Download
D	tools/dom/templates/html/dart2js/impl_WorkerContext.darttemplate	View	1	1 chunk	+0 lines, -24 lines	0 comments	Download
A	tools/dom/templates/html/impl/impl_DirectoryEntry.darttemplate	View	1	1 chunk	+47 lines, -0 lines	0 comments	Download
A +	tools/dom/templates/html/impl/impl_EventSource.darttemplate	View		1 chunk	+5 lines, -3 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_MutationObserver.darttemplate	View		2 chunks	+1 line, -15 lines	0 comments	Download
A	tools/dom/templates/html/impl/impl_Notification.darttemplate	View	1 2	1 chunk	+22 lines, -0 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Window.darttemplate	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download
A	tools/dom/templates/html/impl/impl_WorkerContext.darttemplate	View	1	1 chunk	+57 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

https://codereview.chromium.org/12531013/diff/2001/tools/dom/templates/html/impl/impl_EventSource.darttemplate File tools/dom/templates/html/impl/impl_EventSource.darttemplate (left): https://codereview.chromium.org/12531013/diff/2001/tools/dom/templates/html/impl/impl_EventSource.darttemplate#oldcode9 tools/dom/templates/html/impl/impl_EventSource.darttemplate:9: return JS('RtcIceCandidate', 'new RTCIceCandidate(#)', sometimes git tries to be ...

7 years, 9 months ago (2013-03-14 22:34:47 UTC) #1

blois

https://codereview.chromium.org/12531013/diff/28001/sdk/lib/html/dart2js/html_dart2js.dart File sdk/lib/html/dart2js/html_dart2js.dart (right): https://codereview.chromium.org/12531013/diff/28001/sdk/lib/html/dart2js/html_dart2js.dart#newcode10380 sdk/lib/html/dart2js/html_dart2js.dart:10380: + 'withCredentials': withCredentials, The keys should probably not be ...

7 years, 9 months ago (2013-03-15 20:35:31 UTC) #3

Emily Fortuna

ptal. https://codereview.chromium.org/12531013/diff/28001/sdk/lib/html/dart2js/html_dart2js.dart File sdk/lib/html/dart2js/html_dart2js.dart (right): https://codereview.chromium.org/12531013/diff/28001/sdk/lib/html/dart2js/html_dart2js.dart#newcode18224 sdk/lib/html/dart2js/html_dart2js.dart:18224: + return Notification._factoryNotification(title, parsedOptions); On 2013/03/15 20:35:31, blois ...

7 years, 9 months ago (2013-03-15 21:01:52 UTC) #4

Emily Fortuna

7 years, 9 months ago (2013-03-15 23:46:27 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 manually as r20127 (presubmit successful).

Expand Messages | Collapse Messages