Issue 12628003: Fix crash in issue 8919. The test still fails.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12628003: Fix crash in issue 8919. The test still fails. (Closed)

Created:
7 years, 9 months ago by srdjan

Modified:
7 years, 9 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix crash in issue 8919. The test still fails. Committed: https://code.google.com/p/dart/source/detail?r=19657

Patch Set 3 : #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -12 lines)			Patch
	M	runtime/vm/flow_graph_builder.cc	View	1 2	1 chunk	+11 lines, -9 lines	0 comments	Download
	M	tests/language/language.status	View		3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

hausner

LGTM w/comment https://codereview.chromium.org/12628003/diff/3001/runtime/vm/flow_graph_builder.cc File runtime/vm/flow_graph_builder.cc (right): https://codereview.chromium.org/12628003/diff/3001/runtime/vm/flow_graph_builder.cc#newcode2724 runtime/vm/flow_graph_builder.cc:2724: // we save the stored value if ...

7 years, 9 months ago (2013-03-07 21:53:59 UTC) #2

srdjan

https://codereview.chromium.org/12628003/diff/3001/runtime/vm/flow_graph_builder.cc File runtime/vm/flow_graph_builder.cc (right): https://codereview.chromium.org/12628003/diff/3001/runtime/vm/flow_graph_builder.cc#newcode2724 runtime/vm/flow_graph_builder.cc:2724: // we save the stored value if the result ...

7 years, 9 months ago (2013-03-07 21:58:08 UTC) #3

srdjan

7 years, 9 months ago (2013-03-07 21:59:06 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r19657 (presubmit successful).

Expand Messages | Collapse Messages

Issue 12628003: Fix crash in issue 8919. The test still fails. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages