Fix crash in issue 8919. The test still fails.

runtime/vm/flow_graph_builder.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/flow_graph_builder.h"
 
 #include "lib/invocation_mirror.h"
 #include "vm/ast_printer.h"
 #include "vm/code_descriptors.h"
 #include "vm/dart_entry.h"
@@ skipping 2702 matching lines @@
     bool result_is_needed) {
   Function* super_function = NULL;
   if (node->IsSuperStore()) {
     // Resolve the store indexed operator in the super class.
     super_function = &Function::ZoneHandle(
         Resolver::ResolveDynamicAnyArgs(node->super_class(),
                                         Symbols::AssignIndexToken()));
     if (super_function->IsNull()) {
       // Could not resolve super operator. Generate call noSuchMethod() of the
       // super class instead.
-      if (result_is_needed) {
         // Even though noSuchMethod most likely does not return,
         // we save the stored value if the result is needed.

[hausner, 2013/03/07 21:53:59]

Can you adjust the comment to match the removed if statement?

[srdjan, 2013/03/07 21:58:08]

Done.

-        ValueGraphVisitor for_value(owner(), temp_index());
-        node->value()->Visit(&for_value);
-        Append(for_value);
-        Bind(BuildStoreExprTemp(for_value.value()));
-      }
+      ValueGraphVisitor for_value(owner(), temp_index());
+      node->value()->Visit(&for_value);
+      Append(for_value);
+      Do(BuildStoreExprTemp(for_value.value()));
+
+      const LocalVariable* temp =
+          owner()->parsed_function().expression_temp_var();
+      AstNode* value = new LoadLocalNode(node->token_pos(), temp);
       ArgumentListNode* arguments = new ArgumentListNode(node->token_pos());
       arguments->Add(node->array());
       arguments->Add(node->index_expr());
-      arguments->Add(node->value());
+      arguments->Add(value);
       StaticCallInstr* call =
           BuildStaticNoSuchMethodCall(node->super_class(),
                                       node->array(),
                                       Symbols::AssignIndexToken(),
                                       arguments);
       if (result_is_needed) {
         Do(call);
         return BuildLoadExprTemp();
       } else {
         return call;
@@ skipping 545 matching lines @@
   intptr_t len = OS::SNPrint(NULL, 0, kFormat, function_name, reason) + 1;
   char* chars = Isolate::Current()->current_zone()->Alloc<char>(len);
   OS::SNPrint(chars, len, kFormat, function_name, reason);
   const Error& error = Error::Handle(
       LanguageError::New(String::Handle(String::New(chars))));
   Isolate::Current()->long_jump_base()->Jump(1, error);
 }
 
 
 }  // namespace dart