Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 12625006: Fixing IE10 CORS test. (Closed)

Created:
7 years, 9 months ago by blois
Modified:
7 years, 9 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fixing IE10 CORS test. BUG= Committed: https://code.google.com/p/dart/source/detail?r=20126

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -10 lines) Patch
M tests/html/html.status View 1 chunk +0 lines, -1 line 0 comments Download
M tests/html/xhr_cross_origin_test.dart View 3 chunks +5 lines, -6 lines 0 comments Download
M tools/testing/dart/http_server.dart View 1 chunk +13 lines, -3 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
blois
Was investigating bug 9005 about requests failing on IE10, was able to get this test ...
7 years, 9 months ago (2013-03-13 18:30:47 UTC) #1
Emily Fortuna
lgtm
7 years, 9 months ago (2013-03-13 18:56:54 UTC) #2
blois
Committed patchset #1 manually as r20126 (presubmit successful).
7 years, 9 months ago (2013-03-15 23:35:27 UTC) #3
kustermann
7 years, 9 months ago (2013-03-16 22:41:19 UTC) #4
Message was sent while issue was closed.
Sorry for the late reply.

https://codereview.chromium.org/12625006/diff/1/tools/testing/dart/http_serve...
File tools/testing/dart/http_server.dart (right):

https://codereview.chromium.org/12625006/diff/1/tools/testing/dart/http_serve...
tools/testing/dart/http_server.dart:281: allowedOrigin = '*';
I think this is not the right approach:

You know probably more about CORS/... than I do, but AFAIK browsers should set
the 'Origin' header when they do a cross domain request. And servers (like this
http server) should be able to depend on 'Origin' -- if 'Origin' was not given a
server may want to deny access (and that is a sane behaviour).

If IE10 misbehaves sometimes then we should not change the test or the http
server. Instead we should mark the test in the status file as failing on IE10
and add a comment which says that IE10 is broken and causes the test to fail.

Powered by Google App Engine
This is Rietveld 408576698