Fixing IE10 CORS test.

tools/testing/dart/http_server.dart

Index: tools/testing/dart/http_server.dart
diff --git a/tools/testing/dart/http_server.dart b/tools/testing/dart/http_server.dart
index d065e0bcaac33f64a9dda61127ccee40c4d58c7f..75daee5d988ce150f6853e1dc7eb7d5df3f391f3 100644
--- a/tools/testing/dart/http_server.dart
+++ b/tools/testing/dart/http_server.dart
@@ -268,10 +268,20 @@ class TestingServers {
                         Path path,
                         File file) {
     if (allowedPort != -1) {
-      var origin = new Uri(request.headers.value('Origin'));
-      // Allow loading from http://*:$allowedPort in browsers.
-      var allowedOrigin =
+      var headerOrigin = request.headers.value('Origin');
+      var allowedOrigin;
+      if (headerOrigin != null) {
+        var origin = new Uri(headerOrigin);
+        // Allow loading from http://*:$allowedPort in browsers.
+        allowedOrigin =
           '${origin.scheme}://${origin.domain}:${allowedPort}';
+      } else {
+        // IE10 appears to be bugged and is not sending the Origin header
+        // when making CORS requests to the same domain but different port.
+        allowedOrigin = '*';

[kustermann, 2013/03/16 22:41:19]

I think this is not the right approach:

You know probably more about CORS/... than I do, but AFAIK browsers should set
the 'Origin' header when they do a cross domain request. And servers (like this
http server) should be able to depend on 'Origin' -- if 'Origin' was not given a
server may want to deny access (and that is a sane behaviour).

If IE10 misbehaves sometimes then we should not change the test or the http
server. Instead we should mark the test in the status file as failing on IE10
and add a comment which says that IE10 is broken and causes the test to fail.

+      }
+
+
       response.headers.set("Access-Control-Allow-Origin", allowedOrigin);
       response.headers.set('Access-Control-Allow-Credentials', 'true');
     } else {