Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 1261873005: Migrate stack resource unwinding to Thread. (Closed)

Created:
5 years, 4 months ago by koda
Modified:
5 years, 4 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Migrate stack resource unwinding to Thread. Also remove some uses of deprecated StackResource constructor. BUG= R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/32046b2eb8d6bbe3e28a0231faf159e347a5720c

Patch Set 1 #

Patch Set 2 : Simulators. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -19 lines) Patch
M runtime/vm/allocation.h View 1 chunk +4 lines, -6 lines 0 comments Download
M runtime/vm/allocation.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/vm/cha.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/exceptions.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/log.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/longjump.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M runtime/vm/simulator_arm.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/simulator_arm64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/simulator_mips.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
koda
5 years, 4 months ago (2015-07-29 20:26:03 UTC) #2
koda
Ping?
5 years, 4 months ago (2015-07-30 23:03:30 UTC) #3
siva
lgtm
5 years, 4 months ago (2015-07-30 23:22:44 UTC) #4
koda
5 years, 4 months ago (2015-07-31 19:57:24 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
32046b2eb8d6bbe3e28a0231faf159e347a5720c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698