Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1296)

Unified Diff: runtime/vm/allocation.h

Issue 1261873005: Migrate stack resource unwinding to Thread. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Simulators. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/allocation.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/allocation.h
diff --git a/runtime/vm/allocation.h b/runtime/vm/allocation.h
index f6b74b8e972c49c623defea355ca7c9fe9d1db47..3947f0e79881db294753869df3f3185280f49837 100644
--- a/runtime/vm/allocation.h
+++ b/runtime/vm/allocation.h
@@ -70,12 +70,10 @@ class StackResource {
// The thread that owns this resource.
Thread* thread() const { return thread_; }
- // Destroy stack resources of isolate until top exit frame.
- // TODO(koda): Migrate to Thread.
- static void Unwind(Isolate* isolate) { UnwindAbove(isolate, NULL); }
- // TODO(koda): Migrate to Thread.
- // Destroy stack resources of isolate above new_top, exclusive.
- static void UnwindAbove(Isolate* isolate, StackResource* new_top);
+ // Destroy stack resources of thread until top exit frame.
+ static void Unwind(Thread* thread) { UnwindAbove(thread, NULL); }
+ // Destroy stack resources of thread above new_top, exclusive.
+ static void UnwindAbove(Thread* thread, StackResource* new_top);
private:
void Init(Thread* thread) {
« no previous file with comments | « no previous file | runtime/vm/allocation.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698