update suggestion element return type to have type param

update suggestion element return type to have type param
cleanup loadLibrary suggestion to have correct element

dartbug.com/23905

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/bf05b75f43648b2184fb9e7f59762bdbe746207b

[danrubel, 2015-08-04 00:55:40]

danrubel@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2015-08-04 04:40:13]

LGTM

https://codereview.chromium.org/1260593005/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/protocol_server.dart (right):

https://codereview.chromium.org/1260593005/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/protocol_server.dart:55: return
element.returnType.toString();
Shouldn't this (and line 61) be 'displayName' rather than 'toString()' (after
checking for 'null')?

[danrubel, 2015-08-05 05:08:24]

https://codereview.chromium.org/1260593005/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/protocol_server.dart (right):

https://codereview.chromium.org/1260593005/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/protocol_server.dart:55: return
element.returnType.toString();
On 2015/08/04 04:40:13, Brian Wilkerson wrote:
> Shouldn't this (and line 61) be 'displayName' rather than 'toString()' (after
> checking for 'null')?

displayName does not include the type parameters, but perhaps there is an
accessor that does so that I have missed?

[danrubel, 2015-08-05 05:08:50]

Committed patchset #1 (id:1) manually as
bf05b75f43648b2184fb9e7f59762bdbe746207b (presubmit successful).

[Brian Wilkerson, 2015-08-05 13:19:18]

https://codereview.chromium.org/1260593005/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/protocol_server.dart (right):

https://codereview.chromium.org/1260593005/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/protocol_server.dart:55: return
element.returnType.toString();
> > Shouldn't this (and line 61) be 'displayName' rather than 'toString()'
(after
> > checking for 'null')?
> 
> displayName does not include the type parameters, but perhaps there is an
> accessor that does so that I have missed?

If not, then we need to add one. toString() is strictly for debugging and should
never be displayed to the user.