Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Unified Diff: pkg/analysis_server/lib/src/services/completion/prefixed_element_contributor.dart

Issue 1260593005: update suggestion element return type to have type param (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/completion/prefixed_element_contributor.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/prefixed_element_contributor.dart b/pkg/analysis_server/lib/src/services/completion/prefixed_element_contributor.dart
index 5abb208511d07e5d3d1a32f20af5d097326b6cfd..f8dcbdf2c20c2679d5d412fe4adf788f1f996c09 100644
--- a/pkg/analysis_server/lib/src/services/completion/prefixed_element_contributor.dart
+++ b/pkg/analysis_server/lib/src/services/completion/prefixed_element_contributor.dart
@@ -8,9 +8,12 @@ import 'dart:async';
import 'package:analysis_server/src/services/completion/dart_completion_manager.dart';
import 'package:analysis_server/src/services/completion/local_declaration_visitor.dart';
-import 'package:analysis_server/src/services/completion/local_suggestion_builder.dart';
+import 'package:analysis_server/src/services/completion/local_suggestion_builder.dart'
+ hide createSuggestion;
import 'package:analysis_server/src/services/completion/optype.dart';
import 'package:analysis_server/src/services/completion/suggestion_builder.dart';
+import 'package:analysis_server/src/services/completion/suggestion_builder.dart'
+ show createSuggestion;
import 'package:analyzer/src/generated/ast.dart';
import 'package:analyzer/src/generated/element.dart';
@@ -405,20 +408,8 @@ class _PrefixedIdentifierSuggestionBuilder
request.target.containingNode.parent is TypeName);
modified = true;
if (directive.deferredKeyword != null) {
- String completion = 'loadLibrary';
- CompletionSuggestion suggestion = new CompletionSuggestion(
- CompletionSuggestionKind.INVOCATION, DART_RELEVANCE_DEFAULT,
- completion, completion.length, 0, false, false,
- parameterNames: [],
- parameterTypes: [],
- requiredParameterCount: 0,
- hasNamedParameters: false,
- returnType: 'void');
- suggestion.element = new protocol.Element(
- protocol.ElementKind.FUNCTION, completion,
- protocol.Element.makeFlags(),
- parameters: '()', returnType: 'void');
- request.addSuggestion(suggestion);
+ FunctionElement loadLibFunct = library.loadLibraryFunction;
+ request.addSuggestion(createSuggestion(loadLibFunct));
}
}
}

Powered by Google App Engine
This is Rietveld 408576698