Issue 126053003: Make TestUtils.copyDirectory() more robust by ensureing arguments are a native path

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 126053003: Make TestUtils.copyDirectory() more robust by ensureing arguments are a native path (Closed)

Created:
6 years, 11 months ago by kustermann

Modified:
6 years, 11 months ago

Reviewers:
ricow1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Make TestUtils.copyDirectory() more robust by ensureing arguments are a native path Committed: https://code.google.com/p/dart/source/detail?r=31550

Patch Set 1 #

Total comments: 1

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	dart/tools/testing/dart/test_suite.dart	View		1 chunk	+4 lines, -1 line	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kustermann

https://codereview.chromium.org/126053003/diff/1/dart/tools/testing/dart/test_suite.dart File dart/tools/testing/dart/test_suite.dart (right): https://codereview.chromium.org/126053003/diff/1/dart/tools/testing/dart/test_suite.dart#newcode1899 dart/tools/testing/dart/test_suite.dart:1899: args = [source, dest, '/e', '/i']; Either dest has ...

6 years, 11 months ago (2014-01-07 14:52:27 UTC) #1

kustermann

Committed patchset #1 manually as r31550 (presubmit successful).

6 years, 11 months ago (2014-01-07 15:38:23 UTC) #3

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages