Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2315)

Unified Diff: dart/tools/testing/dart/test_suite.dart

Issue 126053003: Make TestUtils.copyDirectory() more robust by ensureing arguments are a native path (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/tools/testing/dart/test_suite.dart
diff --git a/dart/tools/testing/dart/test_suite.dart b/dart/tools/testing/dart/test_suite.dart
index 3bb3b21c93c6a0d49e3465cb9133da7e874bb201..1df99ad1f4f660ac5557cad2f632e6ef0381ef30 100644
--- a/dart/tools/testing/dart/test_suite.dart
+++ b/dart/tools/testing/dart/test_suite.dart
@@ -1889,11 +1889,14 @@ class TestUtils {
}
static Future copyDirectory(String source, String dest) {
+ source = new Path(source).toNativePath();
+ dest = new Path(dest).toNativePath();
+
var executable = 'cp';
var args = ['-Rp', source, dest];
if (Platform.operatingSystem == 'windows') {
executable = 'xcopy';
- args = [source, dest, '/e'];
+ args = [source, dest, '/e', '/i'];
kustermann 2014/01/07 14:52:27 Either dest has to end with a backslash or '/i' ha
}
return Process.run(executable, args).then((ProcessResult result) {
if (result.exitCode != 0) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698