Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issue 12580005: Fail with fatal error instead of segmentation fault if virtual memory allocation fails. (Closed)

Created:
7 years, 9 months ago by Florian Schneider
Modified:
7 years, 9 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fail with fatal error instead of segmentation fault if virtual memory allocation fails. BUG=dart:1754, dart:7995 Committed: https://code.google.com/p/dart/source/detail?r=20315

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M runtime/vm/scavenger.cc View 1 chunk +3 lines, -1 line 0 comments Download
M runtime/vm/virtual_memory.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Florian Schneider
7 years, 9 months ago (2013-03-13 13:40:51 UTC) #1
Ivan Posva
LGTM -ip
7 years, 9 months ago (2013-03-20 01:55:29 UTC) #2
Florian Schneider
7 years, 9 months ago (2013-03-21 13:34:22 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20315 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698