runtime/vm/virtual_memory.cc - Issue 12580005: Fail with fatal error instead of segmentation fault if virtual memory allocation fails.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/virtual_memory.cc

Issue 12580005: Fail with fatal error instead of segmentation fault if virtual memory allocation fails. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/virtual_memory.cc

===================================================================

--- runtime/vm/virtual_memory.cc (revision 19923)

+++ runtime/vm/virtual_memory.cc (working copy)

@@ -15,6 +15,9 @@

ASSERT(Utils::IsPowerOfTwo(alignment));

ASSERT(alignment >= PageSize());

VirtualMemory* result = VirtualMemory::Reserve(size + alignment);

+ if (result == NULL) {

+ FATAL("Out of memory.\n");

+ }

uword start = result->start();

uword real_start = (start + alignment - 1) & ~(alignment - 1);

result->Truncate(real_start, size);

« no previous file with comments | « runtime/vm/scavenger.cc ('k') | no next file » | no next file with comments »