Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 1257953008: Expose content shell's remote debugging URL. (Closed)

Created:
5 years, 4 months ago by nweiz
Modified:
5 years, 4 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Expose content shell's remote debugging URL. Closes #297 R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/bdda5ca70344a38e076854dece9efdf1f814a1fe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -32 lines) Patch
M lib/src/runner.dart View 2 chunks +12 lines, -0 lines 0 comments Download
M lib/src/runner/browser/browser.dart View 1 chunk +8 lines, -0 lines 0 comments Download
M lib/src/runner/browser/browser_manager.dart View 2 chunks +11 lines, -2 lines 0 comments Download
M lib/src/runner/browser/content_shell.dart View 2 chunks +86 lines, -30 lines 0 comments Download
M lib/src/runner/environment.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M lib/src/runner/vm/environment.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M lib/src/util/io.dart View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
5 years, 4 months ago (2015-08-04 23:16:44 UTC) #1
kevmoo
lgtm
5 years, 4 months ago (2015-08-04 23:20:05 UTC) #2
nweiz
5 years, 4 months ago (2015-08-04 23:21:32 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bdda5ca70344a38e076854dece9efdf1f814a1fe (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698