Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: lib/src/runner/browser/browser_manager.dart

Issue 1257953008: Expose content shell's remote debugging URL. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/runner/browser/browser.dart ('k') | lib/src/runner/browser/content_shell.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/runner/browser/browser_manager.dart
diff --git a/lib/src/runner/browser/browser_manager.dart b/lib/src/runner/browser/browser_manager.dart
index 321c1f78c8f88190060a9f8cd3de6bc95b51ba1e..5442d7528d1dfa66af34b93fa60740bf3fac812f 100644
--- a/lib/src/runner/browser/browser_manager.dart
+++ b/lib/src/runner/browser/browser_manager.dart
@@ -151,7 +151,13 @@ class BrowserManager {
Future<_BrowserEnvironment> _loadBrowserEnvironment() async {
var observatoryUrl;
if (_platform.isDartVM) observatoryUrl = await _browser.observatoryUrl;
- return new _BrowserEnvironment(this, observatoryUrl);
+
+ var remoteDebuggerUrl;
+ if (_platform == TestPlatform.contentShell) {
+ remoteDebuggerUrl = await _browser.remoteDebuggerUrl;
+ }
+
+ return new _BrowserEnvironment(this, observatoryUrl, remoteDebuggerUrl);
}
/// Tells the browser the load a test suite from the URL [url].
@@ -285,7 +291,10 @@ class _BrowserEnvironment implements Environment {
final Uri observatoryUrl;
- _BrowserEnvironment(this._manager, this.observatoryUrl);
+ final Uri remoteDebuggerUrl;
+
+ _BrowserEnvironment(this._manager, this.observatoryUrl,
+ this.remoteDebuggerUrl);
CancelableFuture displayPause() => _manager._displayPause();
}
« no previous file with comments | « lib/src/runner/browser/browser.dart ('k') | lib/src/runner/browser/content_shell.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698