Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 125743002: Add HttpRequest::requestedUri. (Closed)

Created:
6 years, 11 months ago by Anders Johnsen
Modified:
6 years, 11 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add HttpRequest::requestedUri. This makes it easier for the user to generate redirect-urls. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=31645

Patch Set 1 #

Patch Set 2 : Provide fall-back host and port. #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -0 lines) Patch
M sdk/lib/io/http.dart View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
M sdk/lib/io/http_impl.dart View 1 2 2 chunks +23 lines, -0 lines 0 comments Download
A tests/standalone/io/http_requested_uri_test.dart View 1 2 1 chunk +49 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Anders Johnsen
6 years, 11 months ago (2014-01-07 06:30:00 UTC) #1
Søren Gjesse
https://codereview.chromium.org/125743002/diff/40001/sdk/lib/io/http.dart File sdk/lib/io/http.dart (right): https://codereview.chromium.org/125743002/diff/40001/sdk/lib/io/http.dart#newcode793 sdk/lib/io/http.dart:793: * The absolute URI for the request (read-only). I ...
6 years, 11 months ago (2014-01-07 11:13:42 UTC) #2
Anders Johnsen
PTAL https://codereview.chromium.org/125743002/diff/40001/sdk/lib/io/http.dart File sdk/lib/io/http.dart (right): https://codereview.chromium.org/125743002/diff/40001/sdk/lib/io/http.dart#newcode793 sdk/lib/io/http.dart:793: * The absolute URI for the request (read-only). ...
6 years, 11 months ago (2014-01-07 13:59:09 UTC) #3
Søren Gjesse
lgtm
6 years, 11 months ago (2014-01-07 16:40:46 UTC) #4
Søren Gjesse
On 2014/01/07 16:40:46, Søren Gjesse wrote: > lgtm But update the description to reflect the ...
6 years, 11 months ago (2014-01-07 16:41:19 UTC) #5
Anders Johnsen
6 years, 11 months ago (2014-01-09 06:43:51 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r31645 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698