Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 1256793006: Stop optimizing uses of "pub list". (Closed)

Created:
5 years, 5 months ago by Paul Berry
Modified:
5 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Stop optimizing uses of "pub list". The use case which made this optimization necessary is now gone, and it's getting in the way of refactoring ContextManager. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/46c284abdf55714f9a8cad9ce07d55825e692a71

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -466 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 3 chunks +4 lines, -5 lines 0 comments Download
M pkg/analysis_server/lib/src/context_manager.dart View 6 chunks +8 lines, -9 lines 0 comments Download
M pkg/analysis_server/lib/src/socket_server.dart View 2 chunks +3 lines, -4 lines 0 comments Download
D pkg/analysis_server/lib/src/source/optimizing_pub_package_map_provider.dart View 1 chunk +0 lines, -136 lines 0 comments Download
M pkg/analysis_server/test/context_manager_test.dart View 2 chunks +0 lines, -37 lines 0 comments Download
M pkg/analysis_server/test/domain_completion_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/mocks.dart View 3 chunks +7 lines, -26 lines 0 comments Download
D pkg/analysis_server/test/source/optimizing_pub_package_map_provider_test.dart View 1 chunk +0 lines, -244 lines 0 comments Download
M pkg/analysis_server/test/source/test_all.dart View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
5 years, 5 months ago (2015-07-24 16:31:54 UTC) #2
Brian Wilkerson
LGTM!
5 years, 5 months ago (2015-07-24 17:36:05 UTC) #3
Paul Berry
5 years, 5 months ago (2015-07-24 17:42:29 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
46c284abdf55714f9a8cad9ce07d55825e692a71 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698