Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: pkg/analysis_server/test/context_manager_test.dart

Issue 1256793006: Stop optimizing uses of "pub list". (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/context_manager_test.dart
diff --git a/pkg/analysis_server/test/context_manager_test.dart b/pkg/analysis_server/test/context_manager_test.dart
index 62e1dd2a409d1654a99aad86bf72f0d551970f1a..44b0a1187fbe238841b67a724071aa43a11c954c 100644
--- a/pkg/analysis_server/test/context_manager_test.dart
+++ b/pkg/analysis_server/test/context_manager_test.dart
@@ -10,7 +10,6 @@ import 'package:analysis_server/src/context_manager.dart';
import 'package:analyzer/file_system/file_system.dart';
import 'package:analyzer/file_system/memory_file_system.dart';
import 'package:analyzer/instrumentation/instrumentation.dart';
-import 'package:analyzer/source/package_map_resolver.dart';
import 'package:analyzer/src/generated/engine.dart';
import 'package:analyzer/src/generated/source.dart';
import 'package:analyzer/src/generated/source_io.dart';
@@ -1380,42 +1379,6 @@ analyzer:
});
}
- test_watch_modifyPackageMapDependency_redundantly() async {
- // Create two dependency files
- String dependencyPath1 = posix.join(projPath, 'dep1');
- String dependencyPath2 = posix.join(projPath, 'dep2');
- resourceProvider.newFile(dependencyPath1, 'contents');
- resourceProvider.newFile(dependencyPath2, 'contents');
- packageMapProvider.dependencies.add(dependencyPath1);
- packageMapProvider.dependencies.add(dependencyPath2);
- // Create a dart file
- String dartFilePath = posix.join(projPath, 'main.dart');
- resourceProvider.newFile(dartFilePath, 'contents');
- // Verify that the created context has the expected empty package map.
- manager.setRoots(<String>[projPath], <String>[], <String, String>{});
- _checkPackageMap(projPath, isEmpty);
- expect(packageMapProvider.computeCount, 1);
- // Set up a different package map
- String packagePath = '/package/foo';
- resourceProvider.newFolder(packagePath);
- packageMapProvider.packageMap = {'foo': projPath};
- // Change both dependencies.
- resourceProvider.modifyFile(dependencyPath1, 'new contents');
- resourceProvider.modifyFile(dependencyPath2, 'new contents');
- // Arrange for the next call to computePackageMap to return the correct
- // timestamps for the dependencies.
- packageMapProvider.modificationTimes = <String, int>{};
- for (String path in [dependencyPath1, dependencyPath2]) {
- File resource = resourceProvider.getResource(path);
- packageMapProvider.modificationTimes[path] = resource.modificationStamp;
- }
- // This should cause the new package map to be picked up, by executing
- // computePackageMap just one additional time.
- await pumpEventQueue();
- _checkPackageMap(projPath, equals(packageMapProvider.packageMap));
- expect(packageMapProvider.computeCount, 2);
- }
-
test_watch_modifyPackagespec() {
String packagesPath = '$projPath/.packages';
String filePath = '$projPath/bin/main.dart';

Powered by Google App Engine
This is Rietveld 408576698