Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 12559013: Revert "Update the test runner to use the new dart:io API" again (Closed)

Created:
7 years, 9 months ago by Søren Gjesse
Modified:
7 years, 9 months ago
Reviewers:
Mads Ager (google)
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Update the test runner to use the new dart:io API" again This reverts r20004 and r20008. TBR=ager@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=20009

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+442 lines, -385 lines) Patch
M tests/standalone/io/status_file_parser_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/standalone/io/test_runner_test.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M tests/standalone/standalone.status View 1 chunk +13 lines, -0 lines 0 comments Download
M tools/release/version.dart View 4 chunks +7 lines, -8 lines 0 comments Download
M tools/test.dart View 7 chunks +13 lines, -24 lines 0 comments Download
M tools/test-runtime.dart View 4 chunks +12 lines, -12 lines 0 comments Download
M tools/testing/bin/linux/dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/testing/bin/macos/dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/testing/bin/windows/dart.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/testing/dart/co19_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/testing/dart/http_server.dart View 9 chunks +53 lines, -65 lines 0 comments Download
M tools/testing/dart/multitest.dart View 4 chunks +7 lines, -5 lines 0 comments Download
M tools/testing/dart/status_file_parser.dart View 2 chunks +36 lines, -33 lines 0 comments Download
M tools/testing/dart/test_options.dart View 2 chunks +9 lines, -9 lines 0 comments Download
M tools/testing/dart/test_progress.dart View 13 chunks +27 lines, -28 lines 0 comments Download
M tools/testing/dart/test_runner.dart View 22 chunks +208 lines, -144 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 14 chunks +32 lines, -33 lines 0 comments Download
M tools/testing/dart/utils.dart View 3 chunks +8 lines, -7 lines 0 comments Download
M tools/testing/dart/vendored_pkg/args/src/usage.dart View 4 chunks +13 lines, -13 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Gjesse
7 years, 9 months ago (2013-03-14 12:13:16 UTC) #1
Søren Gjesse
Committed patchset #1 manually as r20009 (presubmit successful).
7 years, 9 months ago (2013-03-14 12:14:09 UTC) #2
Mads Ager (google)
7 years, 9 months ago (2013-03-14 12:31:00 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698