Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 1255373002: Don't do C++ field guards either when --use_field_guards=false. (Closed)

Created:
5 years, 4 months ago by rmacnak
Modified:
5 years, 4 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't do C++ field guards either when --use_field_guards=false. R=srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/49cdeec99f17807a35fe7d5124dd5bc63fd6b182

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M runtime/vm/object.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
rmacnak
5 years, 4 months ago (2015-07-28 00:57:29 UTC) #2
srdjan
lgtm
5 years, 4 months ago (2015-07-28 05:03:08 UTC) #3
rmacnak
5 years, 4 months ago (2015-07-28 16:45:35 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
49cdeec99f17807a35fe7d5124dd5bc63fd6b182 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698