Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Side by Side Diff: runtime/vm/object.cc

Issue 1255373002: Don't do C++ field guards either when --use_field_guards=false. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/object.h" 5 #include "vm/object.h"
6 6
7 #include "include/dart_api.h" 7 #include "include/dart_api.h"
8 #include "platform/assert.h" 8 #include "platform/assert.h"
9 #include "vm/assembler.h" 9 #include "vm/assembler.h"
10 #include "vm/cpu.h" 10 #include "vm/cpu.h"
(...skipping 7678 matching lines...) Expand 10 before | Expand all | Expand 10 after
7689 set_guarded_list_length(Field::kNoFixedLength); 7689 set_guarded_list_length(Field::kNoFixedLength);
7690 set_guarded_list_length_in_object_offset(Field::kUnknownLengthOffset); 7690 set_guarded_list_length_in_object_offset(Field::kUnknownLengthOffset);
7691 } 7691 }
7692 7692
7693 // Expected class id or nullability of the field changed. 7693 // Expected class id or nullability of the field changed.
7694 return true; 7694 return true;
7695 } 7695 }
7696 7696
7697 7697
7698 void Field::RecordStore(const Object& value) const { 7698 void Field::RecordStore(const Object& value) const {
7699 if (!FLAG_use_field_guards) {
7700 return;
7701 }
7702
7699 if (FLAG_trace_field_guards) { 7703 if (FLAG_trace_field_guards) {
7700 OS::Print("Store %s %s <- %s\n", 7704 OS::Print("Store %s %s <- %s\n",
7701 ToCString(), 7705 ToCString(),
7702 GuardedPropertiesAsCString(), 7706 GuardedPropertiesAsCString(),
7703 value.ToCString()); 7707 value.ToCString());
7704 } 7708 }
7705 7709
7706 if (UpdateGuardedCidAndLength(value)) { 7710 if (UpdateGuardedCidAndLength(value)) {
7707 if (FLAG_trace_field_guards) { 7711 if (FLAG_trace_field_guards) {
7708 OS::Print(" => %s\n", GuardedPropertiesAsCString()); 7712 OS::Print(" => %s\n", GuardedPropertiesAsCString());
(...skipping 13566 matching lines...) Expand 10 before | Expand all | Expand 10 after
21275 return tag_label.ToCString(); 21279 return tag_label.ToCString();
21276 } 21280 }
21277 21281
21278 21282
21279 void UserTag::PrintJSONImpl(JSONStream* stream, bool ref) const { 21283 void UserTag::PrintJSONImpl(JSONStream* stream, bool ref) const {
21280 Instance::PrintJSONImpl(stream, ref); 21284 Instance::PrintJSONImpl(stream, ref);
21281 } 21285 }
21282 21286
21283 21287
21284 } // namespace dart 21288 } // namespace dart
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698