Fix some failing VM tests.

Fix some failing VM tests.

Committed: https://github.com/dart-lang/sdk/commit/90410aabbbd9b9ae0eb63e58477ec2274ce107c8

[nweiz, 2015-07-28 00:01:33]

nweiz@google.com changed reviewers:
+ johnmccutchan@google.com

[nweiz, 2015-07-28 00:01:33]

This fixes tests that are broken for obvious reasons, but vm/cc/Metric_OnDemand
was also broken by my CL and I don't know how to fix it.

[rmacnak, 2015-07-28 00:29:16]

On 2015/07/28 00:01:33, nweiz wrote:
> This fixes tests that are broken for obvious reasons, but
vm/cc/Metric_OnDemand
> was also broken by my CL and I don't know how to fix it.

LGTM

Your change introduced the first handle into that test, but there is no zone to
allocate it in.

Add the following to fix it.

--- a/runtime/vm/metrics_test.cc
+++ b/runtime/vm/metrics_test.cc
@@ -48,6 +48,8 @@ UNIT_TEST_CASE(Metric_OnDemand) {
   vm_flags.CopyTo(&api_flags);
   Isolate* isolate = Isolate::Init(NULL, api_flags);
   EXPECT_EQ(isolate, Isolate::Current());
+  StackZone zone(isolate);
+  HANDLESCOPE(isolate);
   MyMetric metric;

[nweiz, 2015-07-28 00:48:35]

Committed patchset #2 (id:20001) manually as
90410aabbbd9b9ae0eb63e58477ec2274ce107c8 (presubmit successful).