runtime/vm/metrics_test.cc - Issue 1254723013: Fix some failing VM tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/metrics_test.cc

Issue 1254723013: Fix some failing VM tests. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Fix vm/cc/Metric_OnDemand. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/metrics_test.cc

diff --git a/runtime/vm/metrics_test.cc b/runtime/vm/metrics_test.cc

index 364c946422c169aa43506174f61889cb36a4821e..faf425bffd3d3ae85563d7a704b1dec85550823e 100644

--- a/runtime/vm/metrics_test.cc

+++ b/runtime/vm/metrics_test.cc

@@ -48,6 +48,8 @@ UNIT_TEST_CASE(Metric_OnDemand) {

vm_flags.CopyTo(&api_flags);

Isolate* isolate = Isolate::Init(NULL, api_flags);

EXPECT_EQ(isolate, Isolate::Current());

+ StackZone zone(isolate);

+ HANDLESCOPE(isolate);

MyMetric metric;

metric.Init(Isolate::Current(), "a.b.c", "foobar", Metric::kByte);

« no previous file with comments | « no previous file | runtime/vm/service_test.cc » ('j') | no next file with comments »