Issue 12544021: Fix bug 9090: provide the paramter checks arguments to the generative constructor body after the re…

Issue 12544021: Fix bug 9090: provide the paramter checks arguments to the generative constructor body after the re… (Closed)

Created:
7 years, 9 months ago by ngeoffray

Modified:
7 years, 9 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix bug 9090: provide the paramter checks arguments to the generative constructor body after the regular arguments. Committed: https://code.google.com/p/dart/source/detail?r=19916

Patch Set 2 : #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -2 lines)			Patch
	M	sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View	1	1 chunk	+8 lines, -2 lines	0 comments	Download
	A	tests/language/argument_definition6_test.dart	View	1	1 chunk	+26 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. https://codereview.chromium.org/12544021/diff/1/sdk/lib/_internal/compiler/implementation/ssa/builder.dart File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right): https://codereview.chromium.org/12544021/diff/1/sdk/lib/_internal/compiler/implementation/ssa/builder.dart#newcode1483 sdk/lib/_internal/compiler/implementation/ssa/builder.dart:1483: // last parameter. So no need to direclty ...

7 years, 9 months ago (2013-03-13 09:43:47 UTC) #2

ngeoffray

Thanks Kasper. https://codereview.chromium.org/12544021/diff/1/sdk/lib/_internal/compiler/implementation/ssa/builder.dart File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right): https://codereview.chromium.org/12544021/diff/1/sdk/lib/_internal/compiler/implementation/ssa/builder.dart#newcode1483 sdk/lib/_internal/compiler/implementation/ssa/builder.dart:1483: // last parameter. So no need to ...

7 years, 9 months ago (2013-03-13 09:55:28 UTC) #3

ngeoffray

7 years, 9 months ago (2013-03-13 09:55:51 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r19916 (presubmit successful).

Expand Messages | Collapse Messages