Fix bug 9090: provide the paramter checks arguments to the generative constructor body after the re…

sdk/lib/_internal/compiler/implementation/ssa/builder.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of ssa;
 
 /**
  * A special element for the extra parameter taken by intercepted
  * methods. We need to override [Element.computeType] because our
  * optimizers may look at its declared type.
@@ skipping 1459 matching lines @@
       List bodyCallInputs = <HInstruction>[];
       bodyCallInputs.add(newObject);
       TreeElements elements =
           compiler.enqueuer.resolution.getCachedElements(constructor);
       Node node = constructor.parseNode(compiler);
       ClosureClassMap parameterClosureData =
           compiler.closureToClassMapper.getMappingForNestedFunction(node);
 
 
       FunctionSignature functionSignature = body.computeSignature(compiler);
+      // Provide the parameters to the generative constructor body.
       functionSignature.orderedForEachParameter((parameter) {
-        // if [parameter] is boxed, it will be a field in the box passed as the
+        // If [parameter] is boxed, it will be a field in the box passed as the
         // last parameter. So no need to direclty pass it.

[kasperl, 2013/03/13 09:43:47]

direclty -> directly

[ngeoffray, 2013/03/13 09:55:28]

Done.

         if (!localsHandler.isBoxed(parameter)) {
           bodyCallInputs.add(localsHandler.readLocal(parameter));
         }
+      });
+
+      // Provide the parameter checks to the generative constructor
+      // body.
+      functionSignature.orderedForEachParameter((parameter) {
         // If [parameter] is checked, we pass the already computed
         // boolean to the constructor body.
         if (elements.isParameterChecked(parameter)) {
           Element fieldCheck =
               parameterClosureData.parametersWithSentinel[parameter];
           bodyCallInputs.add(localsHandler.readLocal(fieldCheck));
         }
       });
 
       ClassElement currentClass = constructor.getEnclosingClass();
@@ skipping 3614 matching lines @@
           new HSubGraphBlockInformation(elseBranch.graph));
 
     HBasicBlock conditionStartBlock = conditionBranch.block;
     conditionStartBlock.setBlockFlow(info, joinBlock);
     SubGraph conditionGraph = conditionBranch.graph;
     HIf branch = conditionGraph.end.last;
     assert(branch is HIf);
     branch.blockInformation = conditionStartBlock.blockFlow;
   }
 }