Issue 1252703002: VM: Use object pool for loading Symbols::PredefinedAddress in intrinsic code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1252703002: VM: Use object pool for loading Symbols::PredefinedAddress in intrinsic code. (Closed)

Created:
5 years, 5 months ago by Florian Schneider

Modified:
5 years, 5 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

VM: Use object pool for loading Symbols::PredefinedAddress in intrinsic code. ia32 is unchanged since we don't have an object pool there. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/a27ce8c7cf6f33e991f3fc3993211fa0da379e42

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -17 lines)			Patch
M	runtime/vm/assembler_x64.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm64.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/intrinsifier_arm.cc	View	1	2 chunks	+14 lines, -4 lines	0 comments	Download
M	runtime/vm/intrinsifier_arm64.cc	View	1 2	2 chunks	+14 lines, -4 lines	0 comments	Download
M	runtime/vm/intrinsifier_mips.cc	View	1	2 chunks	+18 lines, -4 lines	0 comments	Download
M	runtime/vm/intrinsifier_x64.cc	View	1	2 chunks	+14 lines, -4 lines	0 comments	Download

Total messages: 5 (1 generated)

rmacnak

LGTM Add asserts to StringFromCharCodeInstr::EmitNativeCode that we're generating optimized code.

5 years, 5 months ago (2015-07-23 17:25:45 UTC) #3

Florian Schneider

5 years, 5 months ago (2015-07-24 11:57:30 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 (id:20002) manually as
a27ce8c7cf6f33e991f3fc3993211fa0da379e42 (presubmit successful).