runtime/vm/intrinsifier_x64.cc - Issue 1252703002: VM: Use object pool for loading Symbols::PredefinedAddress in intrinsic code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intrinsifier_x64.cc

Issue 1252703002: VM: Use object pool for loading Symbols::PredefinedAddress in intrinsic code. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: add missing code on arm64 Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intrinsifier_x64.cc

diff --git a/runtime/vm/intrinsifier_x64.cc b/runtime/vm/intrinsifier_x64.cc

index ee104c683a39a692034788732cfa79f0ad157372..a034e69d36a4a0faabb46c476d9124478a9e2be0 100644

--- a/runtime/vm/intrinsifier_x64.cc

+++ b/runtime/vm/intrinsifier_x64.cc

@@ -1609,8 +1609,14 @@ void Intrinsifier::StringBaseCharAt(Assembler* assembler) {

__ movzxb(RCX, FieldAddress(RAX, RCX, TIMES_1, OneByteString::data_offset()));

__ cmpq(RCX, Immediate(Symbols::kNumberOfOneCharCodeSymbols));

__ j(GREATER_EQUAL, &fall_through);

- __ movq(RAX,

- Immediate(reinterpret_cast<uword>(Symbols::PredefinedAddress())));

+ const ExternalLabel symbols_label(

+ reinterpret_cast<uword>(Symbols::PredefinedAddress()));

+ __ pushq(PP);

+ __ LoadPoolPointer(PP);

+ assembler->set_constant_pool_allowed(true);

+ __ LoadExternalLabel(RAX, &symbols_label, kNotPatchable, PP);

+ assembler->set_constant_pool_allowed(false);

+ __ popq(PP);

__ movq(RAX, Address(RAX,

RCX,

TIMES_8,

@@ -1624,8 +1630,12 @@ void Intrinsifier::StringBaseCharAt(Assembler* assembler) {

__ movzxw(RCX, FieldAddress(RAX, RCX, TIMES_1, OneByteString::data_offset()));