Issue 12510003: Fixing a number of dart:html analyzer issues

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12510003: Fixing a number of dart:html analyzer issues (Closed)

Created:
7 years, 9 months ago by blois

Modified:
7 years, 9 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Fixing a number of dart:html analyzer issues A couple of real bugs, rotten code and deprecated APIs. BUG= Committed: https://code.google.com/p/dart/source/detail?r=19588

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -48 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	5 chunks	+9 lines, -5 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	5 chunks	+10 lines, -12 lines	0 comments	Download
M	sdk/lib/html/html_common/lists.dart	View	1 chunk	+0 lines, -18 lines	0 comments	Download
M	tests/html/element_test.dart	View	2 chunks	+0 lines, -8 lines	0 comments	Download
M	tools/dom/src/CssClassSet.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/src/WrappedList.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/templates/html/impl/impl_Element.darttemplate	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	tools/dom/templates/html/impl/impl_Geolocation.darttemplate	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Window.darttemplate	View	1 chunk	+4 lines, -2 lines	0 comments	Download

Total messages: 5 (0 generated)

Emily Fortuna

can you try re-uploading this? It says "old chunk mismatch" for all the files so ...

7 years, 9 months ago (2013-03-06 19:13:29 UTC) #2

blois

On 2013/03/06 19:13:29, Emily Fortuna wrote: > can you try re-uploading this? It says "old ...

7 years, 9 months ago (2013-03-06 19:24:45 UTC) #3

blois

7 years, 9 months ago (2013-03-06 22:46:44 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r19588 (presubmit successful).