Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Unified Diff: sdk/lib/html/dartium/html_dartium.dart

Side-by-side diff isn't available for this file because of its large size.
Issue 12510003: Fixing a number of dart:html analyzer issues (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « sdk/lib/html/dart2js/html_dart2js.dart ('k') | sdk/lib/html/html_common/lists.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/html/dartium/html_dartium.dart
diff --git a/sdk/lib/html/dartium/html_dartium.dart b/sdk/lib/html/dartium/html_dartium.dart
index 5bb5ce700a3d2748b67ffd817e92c52ff0e8817b..fdf4cac79f5bc13e1f5b4d5581582a6e7d7003b6 100644
--- a/sdk/lib/html/dartium/html_dartium.dart
+++ b/sdk/lib/html/dartium/html_dartium.dart
@@ -10384,7 +10384,8 @@ class _ElementFactoryProvider {
switch (tag) {
case 'td':
case 'th':
- element = _singleNode(_singleNode(table.rows).cells);
+ TableRowElement row = _singleNode(table.rows);
+ element = _singleNode(row.cells);
break;
case 'tr':
element = _singleNode(table.rows);
@@ -12695,14 +12696,9 @@ class Geolocation extends NativeFieldWrapperClass1 {
}
Geoposition _ensurePosition(domPosition) {
- try {
- // Firefox may throw on this.
- if (domPosition is Geoposition) {
- return domPosition;
- }
- } catch(e) {}
- return new _GeopositionWrapper(domPosition);
+ return domPosition;
}
+
Geolocation.internal();
@DomName('Geolocation.clearWatch')
@@ -28080,8 +28076,10 @@ class Window extends EventTarget implements WindowBase {
* [animationFrame] again for the animation to continue.
*/
Future<num> get animationFrame {
- var completer = new Completer<int>();
- requestAnimationFrame(completer.complete);
+ var completer = new Completer<num>();
+ requestAnimationFrame((time) {
+ completer.complete(time);
+ });
return completer.future;
}
@@ -32021,7 +32019,7 @@ abstract class CssClassSet implements Set<String> {
Iterable<String> where(bool f(String element)) => readClasses().where(f);
- Iterable expand(Iterable f(String element)) => readClasses.expand(f);
+ Iterable expand(Iterable f(String element)) => readClasses().expand(f);
bool every(bool f(String element)) => readClasses().every(f);
@@ -33849,7 +33847,7 @@ class _WrappedList<E> implements List<E> {
void set length(int newLength) { _list.length = newLength; }
- void addLast(E value) { _list.addLast(value); }
+ void addLast(E value) { _list.add(value); }
Iterable<E> get reversed => _list.reversed;
« no previous file with comments | « sdk/lib/html/dart2js/html_dart2js.dart ('k') | sdk/lib/html/html_common/lists.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698