Add intersection of disjoint masks to the TypeMask implementation.

Add intersection of disjoint masks to the TypeMask implementation.


R=ngeoffray@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=19614

[ngeoffray, 2013-03-07 10:09:44]

LGTM

https://codereview.chromium.org/12509005/diff/3001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/types/type_mask.dart (right):

https://codereview.chromium.org/12509005/diff/3001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/types/type_mask.dart:278: // because
we wouldn't need a disjoint intersection otherwise.
Remove otherwise at the end (it already starts the comment).

https://codereview.chromium.org/12509005/diff/3001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/types/type_mask.dart:283: // masks. We
should consider running through the smallest of the two sets
sets.

https://codereview.chromium.org/12509005/diff/3001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/types/type_mask.dart:287: // that do
not have a superclass or supertype that will be a
Maybe change the end of the comment to:

... or supertype as a candidate. The superclass or the supertype is always a
better candidate.

https://codereview.chromium.org/12509005/diff/3001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/types/type_mask.dart:292: // deal with
this common concrete class. If we're only looking
Remove 'concrete'.

https://codereview.chromium.org/12509005/diff/3001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/types/type_mask.dart:295: // concrete
classes.
Ditto.

https://codereview.chromium.org/12509005/diff/3001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/types/type_mask.dart:297: for (Link
link = each.interfaces; !link.isEmpty; link = link.tail) {
Please add a comment that you iterate over direct supertypes here, and explain
why.

https://codereview.chromium.org/12509005/diff/3001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/types/type_mask.dart:313:
Set<ClassElement> concreteClasses(Compiler compiler) {
concreteClasses -> containedClasses

[kasperl, 2013-03-07 11:36:13]

PTAL. I had to add a hack to the way we deal with malformed checked mode checks.
Nasty.

[ngeoffray, 2013-03-07 11:39:31]

Still LGTM

[kasperl, 2013-03-07 12:20:40]

Committed patchset #8 manually as r19614 (presubmit successful).