sdk/lib/_internal/compiler/implementation/ssa/optimize.dart - Issue 12509005: Add intersection of disjoint masks to the TypeMask implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/optimize.dart

Issue 12509005: Add intersection of disjoint masks to the TypeMask implementation. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Allow base == null. Ugh. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/ssa/nodes.dart ('k') | sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/ssa/optimize.dart

diff --git a/sdk/lib/_internal/compiler/implementation/ssa/optimize.dart b/sdk/lib/_internal/compiler/implementation/ssa/optimize.dart

index 66ed77049f5a2e5d5a9ac7137cb0778f0550a625..9ccb4ede178b595d43f73f6a8d83226d92609c55 100644

--- a/sdk/lib/_internal/compiler/implementation/ssa/optimize.dart

+++ b/sdk/lib/_internal/compiler/implementation/ssa/optimize.dart

@@ -563,6 +563,9 @@ class SsaConstantFolder extends HBaseVisitor implements OptimizationPhase {

}

HInstruction visitTypeConversion(HTypeConversion node) {

+ // TODO(kasperl): This needs cleaning up. We shouldn't be creating

+ // HType objects for malformed types.

+ if (node.isMalformedCheckedModeCheck) return node;

HInstruction value = node.inputs[0];

DartType type = node.instructionType.computeType(compiler);

if (identical(type.element, compiler.dynamicClass)