Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 1250473004: dart2js cps: Cleanup type annotations in type propagation and remove code to handle null continuati… (Closed)

Created:
5 years, 5 months ago by karlklose
Modified:
5 years, 5 months ago
Reviewers:
asgerf
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: Cleanup type annotations in type propagation and remove code to handle null continuation on foreign code node. R=asgerf@google.com Committed: https://github.com/dart-lang/sdk/commit/50bcad9d0b299e1951c5c848688cef1c360e505f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -10 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart View 2 chunks +2 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 3 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
karlklose
5 years, 5 months ago (2015-07-21 07:24:42 UTC) #1
asgerf
LGTM
5 years, 5 months ago (2015-07-21 08:19:57 UTC) #2
karlklose
5 years, 5 months ago (2015-07-21 13:59:54 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
50bcad9d0b299e1951c5c848688cef1c360e505f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698