Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Side by Side Diff: pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart

Issue 1250473004: dart2js cps: Cleanup type annotations in type propagation and remove code to handle null continuati… (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | pkg/compiler/lib/src/cps_ir/type_propagation.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library dart2js.ir_tracer; 5 library dart2js.ir_tracer;
6 6
7 import 'dart:async' show EventSink; 7 import 'dart:async' show EventSink;
8 import 'cps_ir_nodes.dart' as cps_ir hide Function; 8 import 'cps_ir_nodes.dart' as cps_ir hide Function;
9 import '../tracer.dart'; 9 import '../tracer.dart';
10 10
(...skipping 347 matching lines...) Expand 10 before | Expand all | Expand 10 after
358 visitApplyBuiltinOperator(cps_ir.ApplyBuiltinOperator node) { 358 visitApplyBuiltinOperator(cps_ir.ApplyBuiltinOperator node) {
359 String operator = node.operator.toString(); 359 String operator = node.operator.toString();
360 String args = node.arguments.map(formatReference).join(', '); 360 String args = node.arguments.map(formatReference).join(', ');
361 return 'ApplyBuiltinOperator $operator ($args)'; 361 return 'ApplyBuiltinOperator $operator ($args)';
362 } 362 }
363 363
364 @override 364 @override
365 visitForeignCode(cps_ir.ForeignCode node) { 365 visitForeignCode(cps_ir.ForeignCode node) {
366 String id = names.name(node); 366 String id = names.name(node);
367 String arguments = node.arguments.map(formatReference).join(', '); 367 String arguments = node.arguments.map(formatReference).join(', ');
368 String continuation = node.continuation == null ? '' 368 String continuation = formatReference(node.continuation);
369 : ' ${formatReference(node.continuation)}';
370 printStmt(id, "ForeignCode ${node.type} ${node.codeTemplate.source} " 369 printStmt(id, "ForeignCode ${node.type} ${node.codeTemplate.source} "
371 "$arguments $continuation"); 370 "$arguments $continuation");
372 } 371 }
373 372
374 visitGetLength(cps_ir.GetLength node) { 373 visitGetLength(cps_ir.GetLength node) {
375 String object = formatReference(node.object); 374 String object = formatReference(node.object);
376 return 'GetLength $object'; 375 return 'GetLength $object';
377 } 376 }
378 377
379 visitGetIndex(cps_ir.GetIndex node) { 378 visitGetIndex(cps_ir.GetIndex node) {
(...skipping 274 matching lines...) Expand 10 before | Expand all | Expand 10 after
654 visitSetField(cps_ir.SetField node) { 653 visitSetField(cps_ir.SetField node) {
655 unexpectedNode(node); 654 unexpectedNode(node);
656 } 655 }
657 656
658 visitSetStatic(cps_ir.SetStatic node) { 657 visitSetStatic(cps_ir.SetStatic node) {
659 unexpectedNode(node); 658 unexpectedNode(node);
660 } 659 }
661 660
662 @override 661 @override
663 visitForeignCode(cps_ir.ForeignCode node) { 662 visitForeignCode(cps_ir.ForeignCode node) {
664 if (node.continuation != null) { 663 addEdgeToContinuation(node.continuation);
665 addEdgeToContinuation(node.continuation);
666 }
667 } 664 }
668 } 665 }
OLDNEW
« no previous file with comments | « no previous file | pkg/compiler/lib/src/cps_ir/type_propagation.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698