Issue 125033003: Version 1.1.0-dev.5.1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 125033003: Version 1.1.0-dev.5.1 (Closed)

Created:
6 years, 11 months ago by ricow1

Modified:
6 years, 11 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+521 lines, -150 lines)			Patch
M	dart/editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/server/VmUtils.java	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	dart/editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/util/LaunchConfigResourceResolver.java	View	1 chunk	+19 lines, -4 lines	0 comments	Download
M	dart/editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/util/ResourceServerHandler.java	View	9 chunks	+24 lines, -26 lines	0 comments	Download
M	dart/runtime/bin/process_android.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	dart/runtime/bin/process_linux.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	dart/runtime/bin/process_macos.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	dart/runtime/vm/flow_graph_inliner.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	dart/runtime/vm/parser.cc	View	2 chunks	+6 lines, -2 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart	View	2 chunks	+9 lines, -7 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart	View	3 chunks	+61 lines, -9 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View	1 chunk	+9 lines, -8 lines	0 comments	Download
M	dart/sdk/lib/_internal/lib/foreign_helper.dart	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	dart/sdk/lib/_internal/lib/js_helper.dart	View	5 chunks	+346 lines, -74 lines	0 comments	Download
M	dart/sdk/lib/_internal/lib/js_rti.dart	View	1 chunk	+12 lines, -15 lines	0 comments	Download
M	dart/sdk/lib/js/dart2js/js_dart2js.dart	View	1 chunk	+8 lines, -1 line	0 comments	Download
M	dart/tests/compiler/dart2js/mirrors_used_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	dart/tests/compiler/dart2js_native/dart2js_native.status	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	dart/tests/lib/lib.status	View	3 chunks	+3 lines, -0 lines	0 comments	Download
A +	dart/tests/lib/mirrors/syntax_error_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	dart/tools/VERSION	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM if you file a "merge request" issue for Peter's fix.

6 years, 11 months ago (2014-01-06 14:40:34 UTC) #3

ricow1

6 years, 11 months ago (2014-01-06 14:45:49 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r31475 (presubmit successful).

Expand Messages | Collapse Messages