Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart

Issue 125033003: Version 1.1.0-dev.5.1 (Closed) Base URL: http://dart.googlecode.com/svn/trunk/
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart
===================================================================
--- dart/sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart (revision 31466)
+++ dart/sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart (working copy)
@@ -391,6 +391,8 @@
// P. Unmangled name (if reflectable).
// P+1. First metadata (if reflectable).
// ...
+ // TODO(ahe): Consider one of the parameter counts can be replaced by the
+ // length property of the JavaScript function object.
List expressions = [];
@@ -421,14 +423,14 @@
if (member.isInstanceMember()) {
Set invokedSelectors =
compiler.codegenWorld.invokedNames[member.name];
- if (invokedSelectors != null && invokedSelectors.contains(selector)) {
+ //if (invokedSelectors != null && invokedSelectors.contains(selector)) {
expressions.add(js.string(namer.invocationName(selector)));
- } else {
- // Don't add a stub for calling this as a regular instance method,
- // we only need the "call" stub for implicit closures of this
- // method.
- expressions.add("null");
- }
+ //} else {
+ // // Don't add a stub for calling this as a regular instance method,
+ // // we only need the "call" stub for implicit closures of this
+ // // method.
+ // expressions.add("null");
+ //}
} else {
// Static methods don't need "named" stubs as the default arguments
// are inlined at call sites. But static methods might need "call"
« no previous file with comments | « dart/runtime/vm/parser.cc ('k') | dart/sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698