Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 1249793007: performance measurement mods: (Closed)

Created:
5 years, 5 months ago by danrubel
Modified:
5 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

performance measurement mods: * apply source path translation in the order in which they are defined * print elapse times in milliseconds * log overlay content if server exception occurs * simplify diagnostic port initialization * add option to start server using new task model BUG= R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/e196c15ca1ad31cc0b1fade488e4d229a0360cc2

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -72 lines) Patch
M pkg/analysis_server/benchmark/integration/driver.dart View 10 chunks +22 lines, -20 lines 0 comments Download
M pkg/analysis_server/benchmark/integration/input_converter.dart View 10 chunks +53 lines, -27 lines 0 comments Download
M pkg/analysis_server/benchmark/integration/instrumentation_input_converter.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/analysis_server/benchmark/integration/local_runner.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/benchmark/integration/log_file_input_converter.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/analysis_server/benchmark/integration/main.dart View 8 chunks +24 lines, -13 lines 0 comments Download
M pkg/analysis_server/benchmark/integration/operation.dart View 2 chunks +2 lines, -5 lines 0 comments Download
M pkg/analysis_server/test/integration/integration_tests.dart View 3 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
5 years, 5 months ago (2015-07-22 02:51:51 UTC) #2
Brian Wilkerson
LGTM
5 years, 5 months ago (2015-07-22 13:56:20 UTC) #3
danrubel
5 years, 5 months ago (2015-07-22 16:16:17 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
e196c15ca1ad31cc0b1fade488e4d229a0360cc2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698