Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2131)

Unified Diff: pkg/analysis_server/benchmark/integration/operation.dart

Issue 1249793007: performance measurement mods: (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: merge Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/benchmark/integration/operation.dart
diff --git a/pkg/analysis_server/benchmark/integration/operation.dart b/pkg/analysis_server/benchmark/integration/operation.dart
index f9ee62a676aca7661bd3f05696a677dba58442f3..5816a9ed3e3ac7282524846d0fb17440dd5ab075 100644
--- a/pkg/analysis_server/benchmark/integration/operation.dart
+++ b/pkg/analysis_server/benchmark/integration/operation.dart
@@ -169,6 +169,7 @@ class ResponseOperation extends Operation {
'expected error:${format(expectedError)}\n'
'but received:${format(actualResult)}';
driver.results.recordUnexpectedResults(requestJson['method']);
+ converter.logOverlayContent();
if (expectedError == null) {
converter.logger.log(Level.SEVERE, message);
} else {
@@ -179,13 +180,9 @@ class ResponseOperation extends Operation {
}
class StartServerOperation extends Operation {
- final int diagnosticPort;
-
- StartServerOperation({this.diagnosticPort});
-
@override
Future perform(Driver driver) {
- return driver.startServer(diagnosticPort: diagnosticPort);
+ return driver.startServer();
}
}
« no previous file with comments | « pkg/analysis_server/benchmark/integration/main.dart ('k') | pkg/analysis_server/test/integration/integration_tests.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698