Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2632)

Unified Diff: runtime/vm/assembler_arm64.cc

Issue 1249623004: VM: Improve loading of large immediates on ARM64. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_arm64.cc
diff --git a/runtime/vm/assembler_arm64.cc b/runtime/vm/assembler_arm64.cc
index 290890eba5b75a3499ae0bd2a56f5bc2bbe5a1fa..33cd394c96f89477c8e5033f0df5071be3f51e41 100644
--- a/runtime/vm/assembler_arm64.cc
+++ b/runtime/vm/assembler_arm64.cc
@@ -493,17 +493,8 @@ void Assembler::LoadImmediateFixed(Register reg, int64_t imm) {
void Assembler::LoadImmediate(Register reg, int64_t imm, Register pp) {
Comment("LoadImmediate");
if (CanLoadImmediateFromPool(imm, pp)) {
- // It's a 64-bit constant and we're not in the VM isolate, so load from
- // object pool.
- // Save the bits that must be masked-off for the SmiTag
- int64_t val_smi_tag = imm & kSmiTagMask;
- imm &= ~kSmiTagMask; // Mask off the tag bits.
const int32_t offset = ObjectPool::element_offset(FindImmediate(imm));
LoadWordFromPoolOffset(reg, pp, offset);
- if (val_smi_tag != 0) {
- // Add back the tag bits.
- orri(reg, reg, Immediate(val_smi_tag));
- }
} else {
// 0. Is it 0?
if (imm == 0) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698