Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1248483008: Split MessageKind into a MessageKind key and a MessageTemplate. (Closed)

Created:
5 years, 5 months ago by Johnni Winther
Modified:
5 years, 5 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Split MessageKind into a MessageKind key and a MessageTemplate. R=karlklose@google.com Committed: https://github.com/dart-lang/sdk/commit/d7fcc59318ff53a2e3f9aec60d38703322217169

Patch Set 1 #

Patch Set 2 : Update comments. #

Total comments: 6

Patch Set 3 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2342 lines, -1591 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 6 chunks +25 lines, -14 lines 0 comments Download
M pkg/compiler/lib/src/dart2jslib.dart View 3 chunks +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/dump_info.dart View 1 chunk +5 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 2 chunks +5 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/io/start_end_information.dart View 2 chunks +6 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/scanner/listener.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/warnings.dart View 1 2 48 chunks +2224 lines, -1497 lines 0 comments Download
M tests/compiler/dart2js/analyze_only_test.dart View 4 chunks +11 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/compiler_helper.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/compiler/dart2js/compiler_test.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/import_mirrors_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/library_resolution_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/message_kind_helper.dart View 6 chunks +13 lines, -11 lines 0 comments Download
M tests/compiler/dart2js/message_kind_test.dart View 1 chunk +17 lines, -33 lines 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/parser_helper.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/resolver_test.dart View 5 chunks +11 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
Main changes in warnings.dart
5 years, 5 months ago (2015-07-23 10:47:37 UTC) #2
karlklose
LGTM. https://codereview.chromium.org/1248483008/diff/20001/pkg/compiler/lib/src/warnings.dart File pkg/compiler/lib/src/warnings.dart (right): https://codereview.chromium.org/1248483008/diff/20001/pkg/compiler/lib/src/warnings.dart#newcode73 pkg/compiler/lib/src/warnings.dart:73: ABSTRACT_CLASS_INSTANTIATION, The style guide changed to 'In new ...
5 years, 5 months ago (2015-07-23 11:04:00 UTC) #3
Johnni Winther
https://codereview.chromium.org/1248483008/diff/20001/pkg/compiler/lib/src/warnings.dart File pkg/compiler/lib/src/warnings.dart (right): https://codereview.chromium.org/1248483008/diff/20001/pkg/compiler/lib/src/warnings.dart#newcode73 pkg/compiler/lib/src/warnings.dart:73: ABSTRACT_CLASS_INSTANTIATION, On 2015/07/23 11:04:00, karlklose wrote: > The style ...
5 years, 5 months ago (2015-07-23 12:34:47 UTC) #4
Johnni Winther
5 years, 5 months ago (2015-07-23 12:42:44 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
d7fcc59318ff53a2e3f9aec60d38703322217169 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698