Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Side by Side Diff: pkg/compiler/lib/src/dump_info.dart

Issue 1248483008: Split MessageKind into a MessageKind key and a MessageTemplate. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Updated cf. comments. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « pkg/compiler/lib/src/dart2jslib.dart ('k') | pkg/compiler/lib/src/elements/modelx.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library dump_info; 5 library dump_info;
6 6
7 import 'dart:convert' show 7 import 'dart:convert' show
8 HtmlEscape, 8 HtmlEscape,
9 JsonEncoder, 9 JsonEncoder,
10 StringConversionSink, 10 StringConversionSink,
(...skipping 621 matching lines...) Expand 10 before | Expand all | Expand 10 after
632 'noSuchMethodEnabled': backend.enabledNoSuchMethod, 632 'noSuchMethodEnabled': backend.enabledNoSuchMethod,
633 'minified': compiler.enableMinification 633 'minified': compiler.enableMinification
634 }; 634 };
635 635
636 outJson['program'] = generalProgramInfo; 636 outJson['program'] = generalProgramInfo;
637 637
638 ChunkedConversionSink<Object> sink = 638 ChunkedConversionSink<Object> sink =
639 encoder.startChunkedConversion( 639 encoder.startChunkedConversion(
640 new StringConversionSink.fromStringSink(buffer)); 640 new StringConversionSink.fromStringSink(buffer));
641 sink.add(outJson); 641 sink.add(outJson);
642 compiler.reportInfo(NO_LOCATION_SPANNABLE, 642 compiler.reportInfo(
643 const MessageKind( 643 NO_LOCATION_SPANNABLE,
644 "View the dumped .info.json file at " 644 MessageKind.GENERIC,
645 "https://dart-lang.github.io/dump-info-visualizer")); 645 {'text': "View the dumped .info.json file at "
646 "https://dart-lang.github.io/dump-info-visualizer"});
646 } 647 }
647 } 648 }
OLDNEW
« no previous file with comments | « pkg/compiler/lib/src/dart2jslib.dart ('k') | pkg/compiler/lib/src/elements/modelx.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698