Issue 12476021: Handle /dev/null on linux, as an closed device.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12476021: Handle /dev/null on linux, as an closed device. (Closed)

Created:
7 years, 9 months ago by Anders Johnsen

Modified:
7 years, 6 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Handle /dev/null on linux, as an closed device. This will make all devices unsupported by epoll act as an empty source. BUG= Committed: https://code.google.com/p/dart/source/detail?r=19796

Patch Set 2 : Add support for reading /dev/null on mac. #

Patch Set 3 : Apply same fix for mac #

Total comments: 2

Patch Set 4 : Remove debug print. #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -17 lines)			Patch
M	runtime/bin/eventhandler_linux.cc	View		1 chunk	+8 lines, -1 line	0 comments	Download
M	runtime/bin/eventhandler_macos.cc	View	1 2	1 chunk	+9 lines, -1 line	0 comments	Download
M	runtime/bin/file_linux.cc	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/bin/file_macos.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	tests/standalone/io/dart_std_io_pipe_test.dart	View		3 chunks	+30 lines, -13 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm - passes all standalone tests on Mac OS https://codereview.chromium.org/12476021/diff/5001/runtime/bin/file_linux.cc File runtime/bin/file_linux.cc (right): https://codereview.chromium.org/12476021/diff/5001/runtime/bin/file_linux.cc#newcode126 runtime/bin/file_linux.cc:126: ...

7 years, 9 months ago (2013-03-11 15:08:16 UTC) #2

Anders Johnsen

Committed patchset #4 manually as r19796 (presubmit successful).

7 years, 9 months ago (2013-03-11 15:16:17 UTC) #3