runtime/bin/file_linux.cc - Issue 12476021: Handle /dev/null on linux, as an closed device.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/file_linux.cc

Issue 12476021: Handle /dev/null on linux, as an closed device. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Remove debug print. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/bin/file_linux.cc

diff --git a/runtime/bin/file_linux.cc b/runtime/bin/file_linux.cc

index ce0ef27bb26c5ea84f21e13424b345098c4d2f4e..df43d2d86c9788693a7b9b563123a1160b2963e3 100644

--- a/runtime/bin/file_linux.cc

+++ b/runtime/bin/file_linux.cc

@@ -107,7 +107,8 @@ File* File::Open(const char* name, FileOpenMode mode) {

// Report errors for non-regular files.

struct stat st;

if (TEMP_FAILURE_RETRY(stat(name, &st)) == 0) {

- if (!S_ISREG(st.st_mode)) {

+ // Only accept regular files and character devices.

+ if (!S_ISREG(st.st_mode) && !S_ISCHR(st.st_mode)) {

errno = (S_ISDIR(st.st_mode)) ? EISDIR : ENOENT;

return NULL;

}

« no previous file with comments | « runtime/bin/eventhandler_macos.cc ('k') | runtime/bin/file_macos.cc » ('j') | no next file with comments »