Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 1245833003: dart2js: Support checked setters in the program builder. (Closed)

Created:
5 years, 5 months ago by floitsch
Modified:
5 years, 5 months ago
CC:
reviews_dartlang.org, Siggi Cherem (dart-lang)
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: Support checked setters in the program builder. R=karlklose@google.com Committed: https://github.com/dart-lang/sdk/commit/39d3812bc0464aa93849787a3c610e6f650d3d52

Patch Set 1 #

Patch Set 2 : Fix bad copy/paste. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -23 lines) Patch
M pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart View 1 2 chunks +9 lines, -21 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/model.dart View 4 chunks +6 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart View 4 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
floitsch
5 years, 5 months ago (2015-07-21 11:56:13 UTC) #2
karlklose
LGTM.
5 years, 5 months ago (2015-07-21 12:12:17 UTC) #3
floitsch
Committed patchset #2 (id:20001) manually as 39d3812bc0464aa93849787a3c610e6f650d3d52 (presubmit successful).
5 years, 5 months ago (2015-07-21 12:13:57 UTC) #4
Siggi Cherem (dart-lang)
5 years, 5 months ago (2015-07-21 20:35:21 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698