Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Unified Diff: pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart

Issue 1245833003: dart2js: Support checked setters in the program builder. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Fix bad copy/paste. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/compiler/lib/src/js_emitter/model.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart
diff --git a/pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart b/pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart
index c12637cac3f2ffce9369c48c6f239e02b244868d..10e2792184fc4a1c7e1e8f76a3dbb6415b4c1303 100644
--- a/pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart
+++ b/pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart
@@ -193,14 +193,15 @@ class ClassEmitter extends CodeEmitterHelper {
void emitCheckedClassSetters(Class cls, ClassBuilder builder) {
if (cls.onlyForRti) return;
- for (Field field in cls.fields) {
- if (field.needsCheckedSetter) {
- assert(!field.needsUncheckedSetter);
- compiler.withCurrentElement(field.element, () {
- generateCheckedSetter(
- field.element, field.name, field.accessorName, builder);
- });
- }
+ for (StubMethod method in cls.checkedSetters) {
+ Element member = method.element;
+ assert(member != null);
+ jsAst.Expression code = method.code;
+ jsAst.Name setterName = method.name;
+ compiler.dumpInfoTask.registerElementAst(member,
+ builder.addProperty(setterName, code));
+ generateReflectionDataForFieldGetterOrSetter(
+ member, setterName, builder, isGetter: false);
}
}
@@ -376,19 +377,6 @@ class ClassEmitter extends CodeEmitterHelper {
message: '$previousName != ${memberName}'));
}
- void generateCheckedSetter(Element member,
- jsAst.Name fieldName,
- jsAst.Name accessorName,
- ClassBuilder builder) {
- jsAst.Expression code = backend.generatedCode[member];
- assert(code != null);
- jsAst.Name setterName = namer.deriveSetterName(accessorName);
- compiler.dumpInfoTask.registerElementAst(member,
- builder.addProperty(setterName, code));
- generateReflectionDataForFieldGetterOrSetter(
- member, setterName, builder, isGetter: false);
- }
-
void emitGetterForCSP(Element member, jsAst.Name fieldName,
jsAst.Name accessorName,
ClassBuilder builder) {
« no previous file with comments | « no previous file | pkg/compiler/lib/src/js_emitter/model.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698