dart2js: fix dependency tracking for deferred loading when types are only used

dart2js: fix dependency tracking for deferred loading when types are only used
in type arguments by the main fragment. (fix #23853)

R=floitsch@google.com

Committed: https://github.com/dart-lang/sdk/commit/4ad37a6107fac443b5229713e4a56fbd66f1b6d5

[floitsch, 2015-07-17 09:22:24]

floitsch@google.com changed reviewers:
+ floitsch@google.com

[floitsch, 2015-07-17 09:22:25]

LGTM.

https://codereview.chromium.org/1244513003/diff/1/pkg/compiler/lib/src/deferr...
File pkg/compiler/lib/src/deferred_load.dart (right):

https://codereview.chromium.org/1244513003/diff/1/pkg/compiler/lib/src/deferr...
pkg/compiler/lib/src/deferred_load.dart:285:
registerTypeArgumentsAsDependencies(type) {
Especially for nested functions I want to have a return type (as it's otherwise
hard to see if it's a function call or not).
It also helps when the argument has a type.

Also one new line before and after nested functions (to make them stick out even
more).

https://codereview.chromium.org/1244513003/diff/1/pkg/compiler/lib/src/deferr...
pkg/compiler/lib/src/deferred_load.dart:286: var dependency = type.element;
We usually don't use "var".

https://codereview.chromium.org/1244513003/diff/1/pkg/compiler/lib/src/resolu...
File pkg/compiler/lib/src/resolution/tree_elements.dart (right):

https://codereview.chromium.org/1244513003/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/tree_elements.dart:178: void forEachType(f) {
missing type on the argument.

https://codereview.chromium.org/1244513003/diff/1/tests/compiler/dart2js_extr...
File tests/compiler/dart2js_extra/23853_test.dart (right):

https://codereview.chromium.org/1244513003/diff/1/tests/compiler/dart2js_extr...
tests/compiler/dart2js_extra/23853_test.dart:8: import 'import_a_23853.dart';
Use descriptive file-names. You can still mention the bug-number here, though.

[floitsch, 2015-07-17 09:22:44]

floitsch@google.com changed reviewers:
+ johnniwinther@google.com

[Siggi Cherem (dart-lang), 2015-07-17 15:34:49]

thx

https://codereview.chromium.org/1244513003/diff/1/pkg/compiler/lib/src/deferr...
File pkg/compiler/lib/src/deferred_load.dart (right):

https://codereview.chromium.org/1244513003/diff/1/pkg/compiler/lib/src/deferr...
pkg/compiler/lib/src/deferred_load.dart:285:
registerTypeArgumentsAsDependencies(type) {
On 2015/07/17 09:22:25, floitsch wrote:
> Especially for nested functions I want to have a return type (as it's
otherwise
> hard to see if it's a function call or not).
> It also helps when the argument has a type.
> 
> Also one new line before and after nested functions (to make them stick out
even
> more).

Done.

https://codereview.chromium.org/1244513003/diff/1/pkg/compiler/lib/src/deferr...
pkg/compiler/lib/src/deferred_load.dart:286: var dependency = type.element;
On 2015/07/17 09:22:25, floitsch wrote:
> We usually don't use "var".

Done.

https://codereview.chromium.org/1244513003/diff/1/pkg/compiler/lib/src/resolu...
File pkg/compiler/lib/src/resolution/tree_elements.dart (right):

https://codereview.chromium.org/1244513003/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/tree_elements.dart:178: void forEachType(f) {
On 2015/07/17 09:22:25, floitsch wrote:
> missing type on the argument.

Done.

https://codereview.chromium.org/1244513003/diff/1/tests/compiler/dart2js_extr...
File tests/compiler/dart2js_extra/23853_test.dart (right):

https://codereview.chromium.org/1244513003/diff/1/tests/compiler/dart2js_extr...
tests/compiler/dart2js_extra/23853_test.dart:8: import 'import_a_23853.dart';
On 2015/07/17 09:22:25, floitsch wrote:
> Use descriptive file-names. You can still mention the bug-number here, though.

Done.

[Siggi Cherem (dart-lang), 2015-07-17 15:45:11]

Patchset #2 (id:20001) has been deleted

[Siggi Cherem (dart-lang), 2015-07-17 15:46:05]

Committed patchset #2 (id:40001) manually as
4ad37a6107fac443b5229713e4a56fbd66f1b6d5 (presubmit successful).