Issue 12431010: Fix String.fromCharCodes to work with iterables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12431010: Fix String.fromCharCodes to work with iterables. (Closed)

Created:
7 years, 9 months ago by Lasse Reichstein Nielsen

Modified:
7 years, 9 months ago

Reviewers:
floitsch, srdjan

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix String.fromCharCodes to work with iterables. BUG=http://dartbug.com/8922 Committed: https://code.google.com/p/dart/source/detail?r=19602

Patch Set 1 #

Total comments: 2

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+84 lines, -52 lines)			Patch
M	runtime/lib/string_base.dart	View	1 chunk	+4 lines, -11 lines	1 comment	Download
M	runtime/lib/string_patch.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/core_patch.dart	View	1 chunk	+1 line, -2 lines	1 comment	Download
M	tests/corelib/string_base_vm_test.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/corelib/string_from_list_test.dart	View	1 chunk	+76 lines, -38 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. https://codereview.chromium.org/12431010/diff/1/runtime/lib/string_base.dart File runtime/lib/string_base.dart (right): https://codereview.chromium.org/12431010/diff/1/runtime/lib/string_base.dart#newcode24 runtime/lib/string_base.dart:24: charCodes = new List<int>.from(charCodes, growable: false); assert that ...

7 years, 9 months ago (2013-03-05 14:14:04 UTC) #2

Lasse Reichstein Nielsen

7 years, 9 months ago (2013-03-07 09:14:52 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r19602 (presubmit successful).

Expand Messages | Collapse Messages