Fix String.fromCharCodes to work with iterables.

runtime/lib/string_base.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * [_StringBase] contains common methods used by concrete String
  * implementations, e.g., _OneByteString.
  */
 class _StringBase {
 
   factory _StringBase._uninstantiable() {
     throw new UnsupportedError(
         "_StringBase can't be instaniated");
   }
 
   int get hashCode native "String_getHashCode";
 
   /**
    *  Create the most efficient string representation for specified
    *  [codePoints].
    */
-  static String createFromCharCodes(List<int> charCodes) {
-    _ObjectArray objectArray;
-    if (charCodes is _ObjectArray) {
-      objectArray = charCodes;
-    } else {
-      int len = charCodes.length;
-      objectArray = new _ObjectArray(len);
-      for (int i = 0; i < len; i++) {
-        objectArray[i] = charCodes[i];
-      }
+  static String createFromCharCodes(Iterable<int> charCodes) {
+    if (charCodes is! _ObjectArray) {
+      charCodes = new List<int>.from(charCodes, growable: false);

[floitsch, 2013/03/05 14:14:04]

assert that it is an _ObjectArray afterwards. (It's not obvious from the List
constructor).
Also, maybe add a comment that ".toList" is not good enough, since that doesn't
guarantee an _ObjectArray.

     }
-    return _createFromCodePoints(objectArray);
+    return _createFromCodePoints(charCodes);
   }
 
   static String _createFromCodePoints(List<int> codePoints)
       native "StringBase_createFromCodePoints";
 
   String operator [](int index) native "String_charAt";
 
   int codeUnitAt(int index) native "String_codeUnitAt";
 
   int get length native "String_getLength";
@@ skipping 560 matching lines @@
     for (int g in groups) {
       result.add(group(g));
     }
     return result;
   }
 
   final int start;
   final String str;
   final String pattern;
 }