Factor cpu profile tree into separate element and expose allocation tracing UI

Factor cpu profile tree into separate element and expose allocation tracing UI

BUG=
R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/4747a63ad6cdab9127f3422e343e971607aeaff2

[Cutch, 2015-07-14 16:06:03]

johnmccutchan@google.com changed reviewers:
+ rmacnak@google.com

[rmacnak, 2015-07-14 17:20:29]

https://codereview.chromium.org/1241653002/diff/40001/runtime/observatory/lib...
File runtime/observatory/lib/src/elements/class_view.dart (right):

https://codereview.chromium.org/1241653002/diff/40001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/class_view.dart:82: return new
Future.value(null).whenComplete(refresh);
new Future(refresh)

https://codereview.chromium.org/1241653002/diff/40001/runtime/observatory/lib...
File runtime/observatory/lib/src/elements/class_view.html (right):

https://codereview.chromium.org/1241653002/diff/40001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/class_view.html:215: <template if="{{
cls.traceAllocations }}">
cls.traceAllocations should be added by this CL?

https://codereview.chromium.org/1241653002/diff/40001/runtime/observatory/lib...
File runtime/observatory/lib/src/elements/cpu_profile.dart (right):

https://codereview.chromium.org/1241653002/diff/40001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/cpu_profile.dart:565: }
else {
  direction = ProfileTreeDirection.Exclusive;
}

If I toggle back and forth.

https://codereview.chromium.org/1241653002/diff/40001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/cpu_profile.dart:569: }
ditto

https://codereview.chromium.org/1241653002/diff/40001/runtime/vm/profiler_ser...
File runtime/vm/profiler_service.cc (right):

https://codereview.chromium.org/1241653002/diff/40001/runtime/vm/profiler_ser...
runtime/vm/profiler_service.cc:1241: sample->first_frame_executing() ||
(sample->allocation_cid() > 0),
is_allocation_sample()

https://codereview.chromium.org/1241653002/diff/40001/runtime/vm/profiler_ser...
runtime/vm/profiler_service.cc:1269: sample->first_frame_executing() ||
(sample->allocation_cid() > 0),
is_allocation_sample()

[Cutch, 2015-07-14 20:02:58]

https://codereview.chromium.org/1241653002/diff/40001/runtime/observatory/lib...
File runtime/observatory/lib/src/elements/class_view.dart (right):

https://codereview.chromium.org/1241653002/diff/40001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/class_view.dart:82: return new
Future.value(null).whenComplete(refresh);
On 2015/07/14 17:20:29, rmacnak wrote:
> new Future(refresh)

Done.

https://codereview.chromium.org/1241653002/diff/40001/runtime/observatory/lib...
File runtime/observatory/lib/src/elements/class_view.html (right):

https://codereview.chromium.org/1241653002/diff/40001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/class_view.html:215: <template if="{{
cls.traceAllocations }}">
On 2015/07/14 17:20:29, rmacnak wrote:
> cls.traceAllocations should be added by this CL?

This has landed now.

https://codereview.chromium.org/1241653002/diff/40001/runtime/observatory/lib...
File runtime/observatory/lib/src/elements/cpu_profile.dart (right):

https://codereview.chromium.org/1241653002/diff/40001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/cpu_profile.dart:565: }
On 2015/07/14 17:20:29, rmacnak wrote:
> else {
>   direction = ProfileTreeDirection.Exclusive;
> }
> 
> If I toggle back and forth.

Acknowledged.

https://codereview.chromium.org/1241653002/diff/40001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/cpu_profile.dart:569: }
On 2015/07/14 17:20:29, rmacnak wrote:
> ditto

Acknowledged.

https://codereview.chromium.org/1241653002/diff/40001/runtime/vm/profiler_ser...
File runtime/vm/profiler_service.cc (right):

https://codereview.chromium.org/1241653002/diff/40001/runtime/vm/profiler_ser...
runtime/vm/profiler_service.cc:1241: sample->first_frame_executing() ||
(sample->allocation_cid() > 0),
On 2015/07/14 17:20:29, rmacnak wrote:
> is_allocation_sample()

Done.

https://codereview.chromium.org/1241653002/diff/40001/runtime/vm/profiler_ser...
runtime/vm/profiler_service.cc:1269: sample->first_frame_executing() ||
(sample->allocation_cid() > 0),
On 2015/07/14 17:20:29, rmacnak wrote:
> is_allocation_sample()

Done.

[rmacnak, 2015-07-14 20:21:05]

lgtm

[Cutch, 2015-07-14 20:56:50]

Committed patchset #8 (id:140001) manually as
4747a63ad6cdab9127f3422e343e971607aeaff2 (presubmit successful).