runtime/vm/profiler_service.cc - Issue 1241653002: Factor cpu profile tree into separate element and expose allocation tracing UI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/profiler_service.cc

Issue 1241653002: Factor cpu profile tree into separate element and expose allocation tracing UI (Closed) Base URL: git@github.com:dart-lang/sdk.git@expose_allocation_profile_service

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/profiler_service.cc

diff --git a/runtime/vm/profiler_service.cc b/runtime/vm/profiler_service.cc

index 7ae43a530a20c82b6764b7996b7d39e433ee995e..bf47f206a1e86b62e3ab09b1a37245ad12c9bad7 100644

--- a/runtime/vm/profiler_service.cc

+++ b/runtime/vm/profiler_service.cc

@@ -1238,7 +1238,7 @@ class ProfileBuilder : public ValueObject {

current,

(j == 0),

- sample->first_frame_executing(),

+ sample->first_frame_executing() || sample->IsAllocationSample(),

true);

}

@@ -1266,7 +1266,7 @@ class ProfileBuilder : public ValueObject {

current,

(j == 0),

- sample->first_frame_executing(),

+ sample->first_frame_executing() || sample->IsAllocationSample(),

false);

}

« no previous file with comments | « runtime/vm/profiler.h ('k') | runtime/vm/tags.cc » ('j') | no next file with comments »