Add type presentation for function types.

Add type presentation for function types.

Committed: https://code.google.com/p/dart/source/detail?r=19540

[ngeoffray, 2013-03-04 10:14:06]

DBC

https://codereview.chromium.org/12393039/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart
(right):

https://codereview.chromium.org/12393039/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart:273:
class TypeRepresentation extends DartTypeVisitor {
Maybe find a way to unit test this visitor?

[karlklose, 2013-03-04 12:15:55]

LGTM.

https://codereview.chromium.org/12393039/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart
(right):

https://codereview.chromium.org/12393039/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart:248:
_getTypeRepresentation(DartType type, String onVariable(variable)) {
Remove one space.

https://codereview.chromium.org/12393039/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart:249: var
visitor = new TypeRepresentation(compiler, onVariable);
Perhaps we can store this object instead of creating a new one everytime.

https://codereview.chromium.org/12393039/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart:271:
typedef String OnVariable(TypeVariableType type);
Perhaps call it 'OnVariableCallback'?

https://codereview.chromium.org/12393039/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart:276:
final StringBuffer builder = new StringBuffer();
If you stored and reused one instance of this class, you have to move the
initialization to getTypeRepresentation.

https://codereview.chromium.org/12393039/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart:286:
String getTypeRepresentation(DartType type) {
I would like documentation on this method to indicate that it is the only
function to be called from outside.

https://codereview.chromium.org/12393039/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart:332:
builder.write(', ret:');
Put a space after ':' (multiple times).

[Johnni Winther, 2013-03-05 16:24:45]

https://codereview.chromium.org/12393039/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart
(right):

https://codereview.chromium.org/12393039/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart:248:
_getTypeRepresentation(DartType type, String onVariable(variable)) {
On 2013/03/04 12:15:55, karlklose wrote:
> Remove one space.

Reinserted the return type instead.

https://codereview.chromium.org/12393039/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart:249: var
visitor = new TypeRepresentation(compiler, onVariable);
On 2013/03/04 12:15:55, karlklose wrote:
> Perhaps we can store this object instead of creating a new one everytime.

Done. [builder] and [onVariable] are now set in the [getTypeRepresentation]
method.

https://codereview.chromium.org/12393039/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart:271:
typedef String OnVariable(TypeVariableType type);
On 2013/03/04 12:15:55, karlklose wrote:
> Perhaps call it 'OnVariableCallback'?

Done.

https://codereview.chromium.org/12393039/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart:273:
class TypeRepresentation extends DartTypeVisitor {
On 2013/03/04 10:14:06, ngeoffray wrote:
> Maybe find a way to unit test this visitor?

Done.

https://codereview.chromium.org/12393039/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart:276:
final StringBuffer builder = new StringBuffer();
On 2013/03/04 12:15:55, karlklose wrote:
> If you stored and reused one instance of this class, you have to move the
> initialization to getTypeRepresentation.

Done.

https://codereview.chromium.org/12393039/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart:286:
String getTypeRepresentation(DartType type) {
On 2013/03/04 12:15:55, karlklose wrote:
> I would like documentation on this method to indicate that it is the only
> function to be called from outside.

Done.

https://codereview.chromium.org/12393039/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart:332:
builder.write(', ret:');
On 2013/03/04 12:15:55, karlklose wrote:
> Put a space after ':' (multiple times).

Done.

[Johnni Winther, 2013-03-06 08:52:44]

Committed patchset #5 manually as r19540 (presubmit successful).